Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/113#discussion_r69839313
--- Diff: core/src/main/java/org/apache/metamodel/util/ResourceUtils.java
---
@@ -18,11 +18,31 @@
*/
package org.apache.metamodel.util;
+import java.net.URI;
+
+import org.apache.metamodel.factory.ResourceFactoryRegistryImpl;
+import org.apache.metamodel.factory.ResourceProperties;
+import org.apache.metamodel.factory.SimpleResourceProperties;
+import org.apache.metamodel.factory.UnsupportedResourcePropertiesException;
+
/**
* Static utility methods for handling {@link Resource}s.
*/
public class ResourceUtils {
+ public static Resource toResource(URI uri) {
+ return toResource(new SimpleResourceProperties(uri));
+ }
+
+ public static Resource toResource(String uri) {
+ return toResource(new SimpleResourceProperties(uri));
+ }
+
+ public static Resource toResource(ResourceProperties
resourceProperties)
+ throws UnsupportedResourcePropertiesException {
--- End diff --
Ah right, but that's IMO more an issue with the overloaded methods :)
Maybe it's a bit of a religious discussion, but I would refer to some good
(IMO) stackoverflow answers on the topic here:
http://stackoverflow.com/questions/20871763/should-i-declare-unchecked-exceptions-in-the-throws-specification
http://stackoverflow.com/questions/25743574/java-best-practice-for-declaring-unchecked-exception
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
