Github user laxmilal-menaria commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/127#discussion_r76641546
--- Diff: jdbc/src/main/java/org/apache/metamodel/jdbc/SqlKeywords.java ---
@@ -58,6 +58,8 @@
KEYWORDS.add("DELETE");
KEYWORDS.add("AND");
KEYWORDS.add("OR");
+ KEYWORDS.add("END");
--- End diff --
Yes, we can add this too, but what happens if we add all keywords in one
shot, is any performance degrade?
Adding columns one by one is not a good approach.
Thoughts?
Thanks,
Laxmilal Menaria
Sent from my iPhone
On Mon, Aug 29, 2016 at 10:07 PM +0530, "Kasper Sørensen"
<[email protected]> wrote:
In jdbc/src/main/java/org/apache/metamodel/jdbc/SqlKeywords.java:
> @@ -58,6 +58,8 @@
> KEYWORDS.add("DELETE");
> KEYWORDS.add("AND");
> KEYWORDS.add("OR");
> + KEYWORDS.add("END");
If we add "END" then we should probably also add "BEGIN" :)
â
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
