Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/133#discussion_r82646932
--- Diff:
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/HiveQueryRewriter.java ---
@@ -35,6 +35,10 @@ public String rewriteColumnType(ColumnType columnType,
Integer columnSize) {
if (columnType == ColumnType.INTEGER) {
return "INT";
}
+ // Hive does not support VARCHAR without a width, nor VARCHAR(MAX).
+ if (columnType == ColumnType.STRING && columnSize == null) {
--- End diff --
Maybe checking with STRING isn't quite enough here. I could imagine a lot
of Hive users using the more specific VARCHAR column type.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
