Github user tomatophantastico commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/156#discussion_r131862185
  
    --- Diff: pom.xml ---
    @@ -330,6 +330,27 @@ under the License.
                                </executions>
                        </plugin>
     
    +                   <plugin>
    +                           <groupId>org.apache.maven.plugins</groupId>
    +                           <artifactId>maven-checkstyle-plugin</artifactId>
    +                           <version>2.17</version>
    +                           <executions>
    +                                   <execution>
    +                                           <id>test</id>
    +                                           <phase>test</phase>
    +                                           <configuration>
    +                                                   
<configLocation>style/checkstyle.xml</configLocation>
    --- End diff --
    
    w.r.t. foldername: 
    i'd prefer naming after function and not implementation, but not really an 
issue to.
    Is the default eclipse formatter used by everyone? Custom files might go 
here as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to