Github user arjansh commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/179#discussion_r189906596
--- Diff:
neo4j/src/main/java/org/apache/metamodel/neo4j/utils/ColumnTypeResolver.java ---
@@ -0,0 +1,117 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.metamodel.neo4j.utils;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Iterator;
+import java.util.List;
+
+import org.apache.metamodel.schema.ColumnType;
+import org.json.JSONException;
+import org.json.JSONObject;
+
+public class ColumnTypeResolver {
+ public ColumnType[] getColumnTypes(final JSONObject jsonObject, final
String[] columnNamesArray) {
+ final List<String> columnNames = new
ArrayList<>(Arrays.asList(columnNamesArray));
+ final List<ColumnType> columnTypes = new ArrayList<>();
+
+ try {
+ fillColumnTypesFromMetadata(jsonObject, columnNames,
columnTypes);
+ fillColumnTypesFromData(jsonObject, columnNames, columnTypes);
+ } catch (final JSONException e) {
+ // ignore missing data
+ }
+
+ fillColumnTypesFromRemainingColumns(columnNames, columnTypes);
+ return columnTypes.toArray(new ColumnType[columnTypes.size()]);
+ }
+
+ private void fillColumnTypesFromData(final JSONObject jsonObject,
final List<String> columnNames,
+ final List<ColumnType> columnTypes) throws JSONException {
+ final String dataKey = "data";
+
+ if (jsonObject.has(dataKey)) {
+ final JSONObject data = jsonObject.getJSONObject(dataKey);
+ final Iterator keysIterator = data.keys();
--- End diff --
Iterator is a raw type. References to generic type Iterator<E> should be
parameterized.
---
