kaspersorensen commented on a change in pull request #211: METAMODEL-1207: fix 
regex pattern in order to fetch the correct version in all cases
URL: https://github.com/apache/metamodel/pull/211#discussion_r263957905
 
 

 ##########
 File path: 
jdbc/src/test/java/org/apache/metamodel/jdbc/dialects/OracleQueryRewriterTest.java
 ##########
 @@ -92,6 +92,14 @@ public void testOffsetFetchVersionCheck() throws 
SQLException {
         Assert.assertEquals("The query shouldn't be rewritten.", 
query.toSql(), qr.rewriteQuery(query));
     }
 
+    @Test
+    public void testOffsetFetchVersionSpecialCaseCheck() throws SQLException {
 
 Review comment:
   I would delete this test case now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to