arjansh commented on a change in pull request #227: MM-1219 Returning schemas
SQL Server
URL: https://github.com/apache/metamodel/pull/227#discussion_r320222385
##########
File path: jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java
##########
@@ -99,6 +99,9 @@
public static final String DATABASE_PRODUCT_HIVE = "Apache Hive";
public static final String DATABASE_PRODUCT_SQLITE = "SQLite";
public static final String DATABASE_PRODUCT_IMPALA = "Impala";
+
+ private static final String DEFAULT_SCHEMA_NAME_SQLSERVER = "dbo";
+ private static final String RESULT_SET_COLUMN_NAME_SCHEMA_SQLSERVER =
"TABLE_SCHEM";
Review comment:
I would propose a different name for this constant, because `'TABLE_SCHEM"`
isn't SQL Server specific. I would instead call it TABLE_SCHEMA_NAME_IDENTIFIER
or SCHEMA_NAME_IDENTIFIER or something similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
