arjansh opened a new pull request #229: Upgrade to Elasticsearch 7.3.1 URL: https://github.com/apache/metamodel/pull/229 Biggest differences between 7.x and 5.x: - Elasticsearch 7.x no longer supports multiple types in indexes, so we can no longer create multiple tables in a schema. - The TransportClient in Elasticsearch has been deprecated. Regarding my proposed changes: - I chose to deprecate the classes in the elasticsearch-native module, but we may also choose to remove that module. - As for the elasticsearch-rest module: -- Because Elasticsearch 7 no longer supports types, I also don't use any of the (now deprecated) apis which can be used to specify a type when using the rest client. -- When trying to create a new table or inserting into a new table when there already is a default type available in the index a MetaModelException will be thrown. -- Elasticsearch 7 has a default type which isn't explicitly used when accessing it, but it is there and it is called "_doc". I added this as a constant, so we can use that as table name when querying Elasticsearch. -- The `ElasticSeachRestUpdateCallback#execute(ActionRequest)` method is public, but I would like to make it package private, because it contains an Elasticsearch internal class in its method signature and is only meant to be used internally by other classes in the same package. Is this something I can just change or do I have to do some evil trickery?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
