arjansh commented on a change in pull request #230: dev/add datatypes to excel
columns
URL: https://github.com/apache/metamodel/pull/230#discussion_r328535756
##########
File path:
excel/src/main/java/org/apache/metamodel/excel/DefaultSpreadsheetReaderDelegate.java
##########
@@ -167,50 +166,114 @@ private MutableTable createTable(final Workbook wb,
final Sheet sheet) {
break;
}
}
-
if (hasColumns) {
- createColumns(table, wb, row);
+ createColumns(table, wb, row, columnTypes);
}
}
-
return table;
}
+ private void setColumnType(Iterator<Row> data, int rowLength, ColumnType[]
columnTypes) {
+ while (data.hasNext()) {
+ Row row = data.next();
+ for (int index = 0; index < rowLength; index++) {
+ if (row.getLastCellNum() == 0) {
+ continue;
+ }
+ if (row.getCell(index) == null) {
+ columnTypes = checkColumnType(ColumnType.STRING,
columnTypes, index);
Review comment:
I really don't like the passing of the columnTypes variable into this method
and then reassigning it to itself here. Can you solve this in a different
manner?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
