SociopathicPixel commented on a change in pull request #230: dev/add datatypes
to excel columns
URL: https://github.com/apache/metamodel/pull/230#discussion_r328566727
##########
File path:
excel/src/main/java/org/apache/metamodel/excel/DefaultSpreadsheetReaderDelegate.java
##########
@@ -167,50 +166,114 @@ private MutableTable createTable(final Workbook wb,
final Sheet sheet) {
break;
}
}
-
if (hasColumns) {
- createColumns(table, wb, row);
+ createColumns(table, wb, row, columnTypes);
}
}
-
return table;
}
+ private void setColumnType(Iterator<Row> data, int rowLength, ColumnType[]
columnTypes) {
+ while (data.hasNext()) {
Review comment:
I had a query to look up only the first 1000records, I see that that got
removed when getting DataRow types instead of the "normal" Row type.
I've added a countdown from 1000 in the while-loop
```
int eagerness = 1000;
...
...
while(data.hasnext() && eagerness-- > 0) {
...
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
