kaspersorensen commented on a change in pull request #240: METAMODEL-1225 Add
ColumnTypingStrategies and use them in CSV module.
URL: https://github.com/apache/metamodel/pull/240#discussion_r406671163
##########
File path:
csv/src/main/java/org/apache/metamodel/csv/CsvDataContextFactory.java
##########
@@ -59,7 +62,16 @@ public DataContext create(DataContextProperties properties,
ResourceFactoryRegis
columnNamingStrategy = new CustomColumnNamingStrategy(columnNames);
}
- final CsvConfiguration configuration = new
CsvConfiguration(columnNameLineNumber, columnNamingStrategy,
+ final ColumnTypingStrategy columnTypingStrategy;
+ if (properties.getTableDefs() == null) {
+ columnTypingStrategy = null;
+ } else {
+ final SimpleTableDef firstTable = properties.getTableDefs()[0];
Review comment:
Nice touch to use table defs in the factory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
