[GitHub] [metamodel] arjansh commented on a change in pull request #240: METAMODEL-1225 Add ColumnTypingStrategies and use them in CSV module.

[GitBox]

arjansh commented on a change in pull request #240:
URL: https://github.com/apache/metamodel/pull/240#discussion_r450646771



##########
File path: csv/src/main/java/org/apache/metamodel/csv/CsvConfiguration.java
##########
@@ -80,13 +83,15 @@ public CsvConfiguration(int columnNameLineNumber, String 
encoding, char separato
     
     public CsvConfiguration(int columnNameLineNumber, String encoding, char 
separatorChar, char quoteChar,
             char escapeChar, boolean failOnInconsistentRowLength, boolean 
multilineValues) {
-        this(columnNameLineNumber, null, encoding, separatorChar, quoteChar, 
escapeChar, failOnInconsistentRowLength,
-                multilineValues);
+        this(columnNameLineNumber, null, null, encoding, separatorChar, 
quoteChar, escapeChar,
+                failOnInconsistentRowLength, multilineValues);
     }
 
-    public CsvConfiguration(int columnNameLineNumber, ColumnNamingStrategy 
columnNamingStrategy, String encoding,
-            char separatorChar, char quoteChar, char escapeChar, boolean 
failOnInconsistentRowLength,
-            boolean multilineValues) {
+
+    public CsvConfiguration(int columnNameLineNumber, ColumnNamingStrategy 
columnNamingStrategy,

Review comment:
       By replacing the old public constructor with this constructor, compile 
problems can occur in other projects using this library. Can you please retain 
the old constructor and have it invoke this constructor with a `null` value for 
the `ColumnTypeStrategy` parameter?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org