+1 for that Henry. Although I guess we have the general HBase ticket [1],
maybe we need to divide it into smaller chunks.

Took a look at the patch and I think it is a very nice one. The addition to
the core/QueryPostprocessDataContext class is important and something that
can be used also for MongoDbDataContext and maybe also others that do this
type of special handling for "lookup-by-primary-key queries". One very
minor concern is that some tables may potentially have more than one
primaryKey column, but I guess in those cases that the
QueryPostprocessDataContext subclass can then simply decide to not override
the new optimized method.

https://issues.apache.org/jira/browse/METAMODEL-13


2014-03-20 17:29 GMT+01:00 Henry Saputra <[email protected]>:

> Hi Tomasz,
>
> Welcome to Apache MetaModel and thanks for your contribution.
>
> Would you mind creating JIRA ticket [1] to help manage and track this
> contribution? If you have not had Apache JIRA userid you may need to
> create one.
>
> Thanks,
>
> Henry
>
> [1] https://issues.apache.org/jira
>
> On Thu, Mar 20, 2014 at 8:12 AM, Tomasz Guziałek
> <[email protected]> wrote:
> > Hello everyone
> >
> > I submitted a new patch introducing HBase GET implementation for
> MetaModel. You can find it here: https://reviews.apache.org/r/19464/
> >
> > Best regards,
> > Tomasz
>

Reply via email to