Lazy concensus to commit this ...?
2014-06-23 20:08 GMT+02:00 Kasper Sørensen <[email protected]>: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22875/ > Review request for MetaModel. > By Kasper Sørensen. > *Repository: * metamodel > Description > > Proposed solution where the following modules use a new STRING datatype > instead of a JDBC-biased VARCHAR datatype: > > * csv > * fixedwidth > * excel > * xml > > Testing > > Unittests pass. > > Diffs > > - core/src/main/java/org/apache/metamodel/schema/ColumnType.java > (a2b4a2e) > - csv/src/main/java/org/apache/metamodel/csv/CsvTable.java (0fde506) > - > excel/src/main/java/org/apache/metamodel/excel/DefaultSpreadsheetReaderDelegate.java > (c1e2015) > - > excel/src/main/java/org/apache/metamodel/excel/XlsxSheetToRowsHandler.java > (8bae40d) > - > excel/src/main/java/org/apache/metamodel/excel/XlsxSpreadsheetReaderDelegate.java > (810330d) > - > fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthDataContext.java > (58ec92a) > - xml/src/main/java/org/apache/metamodel/xml/XmlDataContext.java > (7738a4e) > - xml/src/main/java/org/apache/metamodel/xml/XmlDomDataContext.java > (5011d04) > - xml/src/main/java/org/apache/metamodel/xml/XmlSaxDataContext.java > (fc22f16) > - xml/src/main/java/org/apache/metamodel/xml/XmlSaxTableDef.java > (368b578) > - xml/src/test/java/org/apache/metamodel/xml/XmlDomDataContextTest.java > (720bb70) > > View Diff <https://reviews.apache.org/r/22875/diff/> >
