Hi Kasper, thank you for the feedback!
I am not sure if I fully understand your piece of advice related to not implement the executeQuery(query) method. I've been having a look at the different modules (jdbc, mongo...) and they do override this method. I've just taken a look at the materializeTable method signature and it does not include, for instance, the FilterItem list so I wouldn't have acces to the filters within this method. I've just commited some changes that allow to add simple where/isEquals clause to the query (although they are inside the executeQuery). I have also just upgraded the dependency to the latest version (thank you!) Kind regards, Alberto 2014-09-12 13:58 GMT+02:00 Kasper Sørensen <i.am.kasper.soren...@gmail.com>: > Hi Alberto, > > I gave you project a quick look, and it's already quite awesome work! :-) I > like the way you discover metadata ... I didn't know of that approach, so I > am looking forward to trying it out. > > A quick thing I noticed is that your DataContext overrides the > executeQuery(Query) method. You probably shouldn't do that, since your > superclass does all the hard work. Simply implement the > materializeTable(...) method and you're much better off. > > If you upgrade your dependency to rely on the latest version of MM (4.2) > then you will even have a lot more helper methods to implement in your > DataContext. Such as executePrimaryKeyLookupQuery and others. Doing that > will quickly get your going to a very broad query support and better > performance. > > Best regards, > Kasper > > > 2014-09-12 13:27 GMT+02:00 Hans Drexler <hans.drex...@humaninference.com>: > > > Just a small correction. MetaModel is not my project. I am not nearly > > smart enough for that. But I'll do my best to give you some worthwhile > > feedback. > > > > Cheers, > > > > Hans > > > > -----Original Message----- > > From: Alberto Rodriguez [mailto:ardl...@gmail.com] > > Sent: Friday, September 12, 2014 1:03 PM > > To: dev@metamodel.incubator.apache.org > > Subject: Re: ElasticSearch Module > > > > Hi Hans, > > > > no worries!! I think your project is awesome and I would like to > > contribute somehow. > > > > I will keep working on the module. > > > > Regards, > > > > Alberto > > > > 2014-09-12 12:58 GMT+02:00 Hans Drexler <hans.drex...@humaninference.com > >: > > > > > Hi Alberto, > > > > > > What great news. I will checkout your code and try to give comments. > > > Thank you for your contributon. > > > > > > Regards, > > > > > > Hans > > > > > > Op 12 sep. 2014 11:13 schreef Alberto Rodriguez <ardl...@gmail.com>: > > > Hi there, > > > > > > as per our previous discussion I have been taking a look at the > > > elasticsearch module for metamodel. > > > > > > I have been working on it and I have a very simple version which is > > > already fetching the metadata from ES. I have also managed to make > > > simple queries work (queries without filters and where clauses). > > > > > > Could you please have a look at the project on my github account and > > > let me know what you think about it?: Metamodel-elasticsearch module > > > <https://github.com/ardlema/metamodel-elasticsearch> > > > > > > Thank you in advance. > > > > > > Kind regards, > > > > > > Alberto > > > > > >
