Hello Kasper, OK for me the reformat and the new thread to clarify the format. ( I liked google's style ;-) )
Regards, 2014-10-06 8:28 GMT+02:00 Kasper Sørensen <i.am.kasper.soren...@gmail.com>: > Hi Francisco - here's what I'll do - I take your diff and then I will > reformat it myself according to my eclipse settings. Then at least when I > commit it will not have a diff full of styling changes. Then I suggest we > start a separate thread on code formatting/style. If we choose to change > the formatting I'd prefer that to be in a single commit with no semantical > changes. > > 2014-10-03 14:46 GMT+02:00 Kasper Sørensen <i.am.kasper.soren...@gmail.com > >: > > > Oh ... Hmm ... Might be a mistake from my side (when writing the > > CONTRIBUTE.md file, or when making the remarks on your Pull Request - > > depending on how you see it)... I think what you did makes a lot of > sense. > > But we should be consistent then. To be honest, all I ever did was to > take > > eclipse defaults and apply the two changes: > > > > * We format indentation using spaces, not tabs. We use 4 spaces for each > > indentation. > > * We format line wrapping using a desired max line length of 120 > > characters. > > > > And that malpractice might have cause this issue to begin with... > > > > So what to do now... Not sure actually. I am OK with ignoring the issues > > for now, but we should probably do a proper reformatting or > re-documenting > > the code style. > > > > > > 2014-10-03 12:54 GMT+02:00 Francisco Javier Cano Bailen < > > fjc...@stratio.com>: > > > >> Hello Kasper, > >> > >> I followed the notes in CONTRIBUTE.md: > >> > >> -------------------------------------- > >> We stick to the [Google Java Style Guide]( > >> http://google-styleguide.googlecode.com/svn/trunk/javaguide.html), > with a > >> few modifications/exceptions: > >> > >> * We often prefix instance variables with an underscore (_). This to > >> easily > >> distinguish between method local and instance variables, as well as > >> avoiding the overuse of the 'this' keyword in e.g. setter methods. > >> * We format indentation using spaces, not tabs. We use 4 spaces for each > >> indentation. > >> * We format line wrapping using a desired max line length of 120 > >> characters. > >> -------------------------------------- > >> > >> I develop on intelliij and before I pushed the changes, I applied the > >> previous format (I configured intellij with the google style xml and I > >> changed indentation space and max line length). > >> > >> What is the right fomat? > >> > >> Regards, > >> > >> > >> 2014-10-02 18:40 GMT+02:00 kaspersorensen <g...@git.apache.org>: > >> > >> > Github user kaspersorensen commented on the pull request: > >> > > >> > > >> > > >> > https://github.com/apache/incubator-metamodel/pull/3#issuecomment-57658518 > >> > > >> > Hi Francisco, > >> > > >> > All the changes look solid and good to me. But I am a bit > concerned > >> > about all the cosmetic changes to indentation, line-width etc. etc. > >> > > >> > To your defense, this is not very well guarded or described. But > >> > here's my "recipe" that has been used in MetaModel: > >> > 1) Make a copy of the defaults in eclipse's java code formatter > >> > 2) Change line width from 80 chars to 120 chars > >> > 3) Change tabs to spaces (4 spaces) > >> > > >> > If you can do that and re-format the classes that you've been > >> working > >> > on, then I think we'll have a much prettier diff and thus better be > >> able to > >> > track actual changes. > >> > > >> > > >> > --- > >> > If your project is set up for it, you can reply to this email and have > >> your > >> > reply appear on GitHub as well. If your project does not have this > >> feature > >> > enabled and wishes so, or if the feature is enabled but not working, > >> please > >> > contact infrastructure at infrastruct...@apache.org or file a JIRA > >> ticket > >> > with INFRA. > >> > --- > >> > > >> > >> > >> > >> -- > >> > >> Francisco Javier Cano > >> Senior Developer > >> > >> > >> <http://www.stratio.com/> > >> Avenida de Europa, 26. Ática 5. 3ª Planta > >> 28224 Pozuelo de Alarcón, Madrid > >> Tel: +34 91 352 59 42 // *@stratiobd <https://twitter.com/StratioBD>* > >> > > > > > -- Francisco Javier Cano Senior Developer <http://www.stratio.com/> Avenida de Europa, 26. Ática 5. 3ª Planta 28224 Pozuelo de Alarcón, Madrid Tel: +34 91 352 59 42 // *@stratiobd <https://twitter.com/StratioBD>*
