Hi Kasper, I've just shipped the revision. It is the first time that I create and submit a revision in Review board, not pretty sure if I should do anything else??
Kind regards, Alberto Rodríguez <http://www.stratio.com/> Avenida de Europa, 26. Ática 5. 3ª Planta 28224 Pozuelo de Alarcón, Madrid Tel: +34 91 352 59 42 // *@stratiobd <https://twitter.com/StratioBD>* 2014-10-21 19:07 GMT+02:00 Kasper Sørensen <i.am.kasper.soren...@gmail.com>: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26975/#review57609 > ----------------------------------------------------------- > > Ship it! > > > Looks good to me. Simple fix is a good fix! :) > > - Kasper Sørensen > > > On okt. 21, 2014, 3:15 p.m., Alberto Rodríguez wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/26975/ > > ----------------------------------------------------------- > > > > (Updated okt. 21, 2014, 3:15 p.m.) > > > > > > Review request for MetaModel. > > > > > > Repository: metamodel > > > > > > Description > > ------- > > > > My proposed fix for METAMODEL-88 > > > > > > Diffs > > ----- > > > > > > elasticsearch/src/test/java/org/apache/metamodel/elasticsearch/ElasticSearchDataContextTest.java > d1794fccd3acdefa1957ea2bd3a9e6a01fd14861 > > > > Diff: https://reviews.apache.org/r/26975/diff/ > > > > > > Testing > > ------- > > > > > > Thanks, > > > > Alberto Rodríguez > > > > > >