Github user justinleet commented on the issue:
https://github.com/apache/incubator-metron/pull/541
Taking a first glance through this and had a couple comments before I dig
in a little further and spin things up.
Can you flesh out the unit tests around the binary filtering? The
converted unit tests are helpful, but it seems like there's probably more cases
than are covered by the couple additions involving.
I'm not familiar with the library, but does this work if I provide things
in a '0x' hex format? E.g. your example has `BYTEARRAY_MATCHER('1F90',
packet)` but will it still work if it's `BYTEARRAY_MATCHER('0x1F90', packet)`?
I don't think it's necessary that it does, but I looked at the example and
immediately suspected I'd have prepended '0x' to '1F90' out of pure habit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
