GitHub user mmiklavc opened a pull request:

    https://github.com/apache/incubator-metron/pull/569

    METRON-936: PCAP topology properties in flux not correctly using 
pcap.properties

    Properties weren't being exposed and required users to modify the flux file 
directly for pcap.
    
    Spin up pcap in full dev and set the number of workers to something other 
than 1. Verify the number of workers in storm and that data is consumed using 
the specified Kafka offset strategy.
    
    ```
    pcap.properties
    ...
    storm.topology.workers=1
    kafka.pcap.start=UNCOMMITTED_EARLIEST
    ...
    ```
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
    - [ ] Have you ensured that the full suite of tests and checks have been 
executed in the root incubating-metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to 
verify your changes?
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mmiklavc/incubator-metron METRON-936

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-metron/pull/569.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #569
    
----
commit 1326dc773f169e46b508be246a6cd3d456e3a17e
Author: Michael Miklavcic <[email protected]>
Date:   2017-05-08T18:18:49Z

    METRON-936: PCAP topology properties in flux not correctly using 
pcap.properties

commit 597df08a77e3a8c78904742dcc8f08b1577670e2
Author: Michael Miklavcic <[email protected]>
Date:   2017-05-08T18:30:49Z

    METRON-936: Fix PCAP integration test

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to