Just merged it

On Tue, May 9, 2017 at 4:26 PM, Otto Fowler <ottobackwa...@gmail.com> wrote:

> Who is going to merge this?
>
>
> On May 9, 2017 at 15:21:07, Justin Leet (justinjl...@gmail.com) wrote:
>
> https://github.com/apache/incubator-metron/pull/575
>
> Somewhat spiffy, since I took the 30 second task of splitting the table
> apart so the parser is less trash and it worked.
>
> On Tue, May 9, 2017 at 3:14 PM, Otto Fowler <ottobackwa...@gmail.com>
> wrote:
>
>> If putting it in a block lets it complete, lets do this and get master
>> going.
>> and we can enter a ticket about making it spiffy like.
>>
>>
>>
>>
>> On May 9, 2017 at 15:05:17, Justin Leet (justinjl...@gmail.com) wrote:
>>
>> Looks like the table of environment variables kills it. An incredibly ugly
>> (like actually looks horrible) hack is to just wrap it in a code block and
>> let it be ugly. Anybody know a less horrible workaround? I'll throw up a
>> PR with this and see if anyone has any ideas, too. At least it'll let
>> people see there's a way to get around it if they need to.
>>
>> I'm guessing we're probably hitting
>> https://issues.apache.org/jira/browse/DOXIA-554.
>>
>> Long story short, the doxia-module-markdown depends on a deprecated
>> library, pegdown, which notably has performance issues (and can result in
>> hangs or infinite loops). It'll be fixed, but not until 1.8 (we're on 1.6,
>> current is 1.7)
>>
>> As an example, my favorite comment is "The issue with pegdown is more
>> serious than that. The simplest pathological case is consecutive
>> [[[[[[[[[[[[[[[[[[[[[[[[[[[, each open bracket doubles parsing time. 18 of
>> these take 1.3 seconds to parse."
>>
>> On Tue, May 9, 2017 at 11:34 AM, Justin Leet <justinjl...@gmail.com>
>> wrote:
>>
>> > https://github.com/apache/incubator-metron/blob/
>> > 716bda326f26b60c98318cdc1cc949b351a0b71a/metron-interface/
>> > metron-rest/README.md appears to be the problem. I can run the site
>> > successfully on the commit before, and this commit hangs.
>> >
>> > Just glancing through, the file appears fine on Github, but there might
>> be
>> > an issue with the rendering the docs. I'm not really familiar enough
>> with
>> > what's going on under the hood to know what the problem is, and I'd
>> have to
>> > dig in more to have an informed opinion.
>> >
>> > Can someone double check me that 716bda32 fails and 38d26d43 succeeds?
>> >
>> > On Tue, May 9, 2017 at 11:26 AM, Otto Fowler <ottobackwa...@gmail.com>
>> > wrote:
>> >
>> >> I also did a >git checkout -b test-site apache/master
>> >> same issue.
>> >>
>> >>
>> >> On May 9, 2017 at 11:09:32, Otto Fowler (ottobackwa...@gmail.com)
>> wrote:
>> >>
>> >> Hi,
>> >> I am running mvn site for the site book, but it never completes. I am
>> >> not sure if there is anything I can do to trouble shoot this?
>> >> I took master into my branch this morning.
>> >>
>> >>
>> >> [INFO]
>> >> [INFO] --- maven-site-plugin:3.4:site (default-site) @ site-book ---
>> >> [INFO] Relativizing decoration links with respect to project URL:
>> >> https://metron.apache.org/
>> >> [INFO] Rendering site with org.apache.maven.skins:maven-f
>> luido-skin:jar:1.3.0
>> >> skin.
>> >> [INFO] Rendering 65 Doxia documents: 65 markdown
>> >>
>> >>
>> >> That is the last output.
>> >>
>> >>
>> >>
>> >
>>
>>
>

Reply via email to