GitHub user mattf-horton opened a pull request:
https://github.com/apache/incubator-metron/pull/578
METRON-946 Full/Quick dev should default network_host to [ _local_, _â¦
## Contributor Comments
@dlyle65535 observed that even single-node installs should have ES bind an
external interface (as well as loopback) so that external clients can access ES
reports. Based on that, FullDev assumes "node1" is bound to an external i/f,
which didn't work with the latest. This patch will fix the problem.
To test, install FullDev and see that the ES config is good.
Also install single node manually and check ES config still good.
There shouldn't be any other observable changes.
## Pull Request Checklist
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [NA] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [NA] Have you written or updated unit tests and or integration tests to
verify your changes?
- [NA] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes: NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattf-horton/incubator-metron METRON-946
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/578.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #578
----
commit 059cf98ce044c61935c8e8d82f46b57af42c8d50
Author: mattf-horton <[email protected]>
Date: 2017-05-10T02:45:44Z
METRON-946 Full/Quick dev should default network_host to [ _local_, _site_ ]
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
