Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/588#discussion_r116582169
--- Diff:
metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/integration/SquidIntegrationTest.java
---
@@ -29,6 +29,11 @@ String getSensorType() {
}
@Override
--- End diff --
We could spin up a new integration test, but I thought this did the trick
and didn't add the cost of another integration test to the build time.
I do have a test ensuring the value gets passed through to the parser.
This just completed the loop. If we don't feel that an integration test is
necessary here, then I can remove it too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
