GitHub user cestella reopened a pull request:
https://github.com/apache/metron/pull/584
METRON-950: Migrate storm-kafka-client to 1.1
## Contributor Comments
There are MAJOR performance issues with the storm-kafka-client. Throughput
is roughly an order of magnitude faster in the 1.1.0 version vs the 1.0.3.
This also removes the requirement for the non-HDP profile to rely on the
HDP repo.
I will point out that the storm-kafka-client in 1.1 does rely on
`Time.nanoTime()`, a method call that was introduced in 1.1. To get around
this, I've created the `metron-storm-kafka-override` with a backported
implementation of the `Time` class. This will be removed when we migrate to
Storm 1.1.
Normally, I would hold off this change until we take the effort to migrate
to 1.1 properly, but the combination of empirical evidence (I saw it go an
order of magnitude slower in 1.0.1 vs 1.1) and wide ranging change for Storm
1.1 makes me err on the side of getting this in faster. It should help make
every topology faster, but is in particular absolutely required to get sensible
throughput in the pcap topology.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron storm_kafka_spout_11
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/584.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #584
----
commit a4cdfdcaaf15c8c60749a103d38b55e77703c2d5
Author: cstella <[email protected]>
Date: 2017-05-12T15:59:18Z
Upgrading spout to 1.1 for performance.
commit 7ef320d3d80324d2322943a7b95354f0ef6c3852
Author: cstella <[email protected]>
Date: 2017-05-12T16:09:57Z
Travis drama.
commit 284c6452d08bc050fe8b1c66e5c85e4a95804cad
Author: cstella <[email protected]>
Date: 2017-05-12T18:09:05Z
Update
commit 4246c36d7fdb94505d789c359c9115728f856e15
Author: cstella <[email protected]>
Date: 2017-05-12T18:48:21Z
Remove ominous warning.
commit 3387d420c3c348ea369d65c6404493483226f105
Author: cstella <[email protected]>
Date: 2017-05-15T19:39:26Z
removed extraneous STREAM
commit a368afb0851b7ae0aa756a2a1c451d48bd941412
Author: cstella <[email protected]>
Date: 2017-05-15T19:50:51Z
Adding test for Timer.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
