Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/596#discussion_r117392109
--- Diff:
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/hdfs/HdfsWriter.java
---
@@ -85,7 +85,17 @@ public void init(Map stormConfig, TopologyContext
topologyContext, WriterConfigu
this.fileNameFormat.prepare(stormConfig,topologyContext);
if(syncPolicy != null) {
//if the user has specified the sync policy, we don't want to
override their wishes.
- syncPolicyCreator = (source,config) -> syncPolicy;
+ syncPolicyCreator = (source,config) -> {
+ try {
--- End diff --
This seems a little black magic-y. Can we expand the comment as to why we
need to clone?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
