Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/581#discussion_r118479511
--- Diff: metron-interface/metron-config/scripts/package.json ---
@@ -9,7 +9,8 @@
"http-proxy-middleware": "0.17.4",
"optimist": "0.6.1",
"serve-favicon": "2.4.2",
--- End diff --
I think a license check for npm dependencies would be a good thing and we
should include it.
Should it be required for this PR? @mattf-horton is preparing the next
release and this is the last PR he's waiting on. If this needs to be included
he should probably proceed without it because I don't think this will be a
quick or easy change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
