Github user justinleet commented on the issue:

    https://github.com/apache/metron/pull/572
  
    Can you use parameterized messages for the various log statements or 
`logger.isDebugEnabled()`, rather than constructing the strings every time?  
The common case is for this to not be run, so I'd rather not have this stuff 
constructed to much. See: https://www.slf4j.org/faq.html#logging_performance
    
    If I recall correctly, typically it's better to use parameterized messages 
if it's just using the `toString()` of an object, and `logger.isDebugEnabled()` 
if not (to avoid whatever calls are made).  I'd have to double check that 
though.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to