Github user kylerichardson commented on the issue:
https://github.com/apache/metron/pull/579
Given these unit tests have been broken for quite some time and @ctramnitz
has thoroughly tested in his environment and that this is a relatively minor
change, I'm okay to move it forward especially with a JIRA in to address these
broken 'AbstractConfigTest' tests holistically in METRON-962.
+1 from me but would prefer a second to commit without tests.
@ctramnitz as discussed please upload public safe sample logs to the JIRA
to assist with test development.
-Kyle
> On Jun 5, 2017, at 5:40 PM, Matt Foley <[email protected]> wrote:
>
> @ctramnitz says (in email): "I didnât touch unit tests because it was
already broken before.
> We agreed to put this into a separate ticket (METRON-962) as it applies
to other parsers as well.
> For now, METRON-941 fixes an actual bug (parsing is broken with the
current code)."
>
> @ottobackwards and @justinleet (principles on METRON-962), do you agree
we should go ahead and commit this without a viable PaloAltoParser unit test?
Or wait for METRON-962?
>
> @kylerichardson , what is your opinion on the issue?
> Thanks.
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
