Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/530
@nickwallen I agree in philosophy, but this has been a running PR for
awhile that had plenty of dev list discussion around it before it was made.
There's already follow-on work being done, and I'm worried that it's going to
be an equally huge burden to split out everything at this point, but all on
@ottobackwards .
I think we should go ahead with this as one PR, and start a discuss thread
laying out the difficulties we've had (both past and present) and make it well
known that we strongly prefer PRs of large scope to come in as multiple,
smaller PRs for the sake of easier, more comprehensive reviewing in the future.
This may involve updating the dev guidelines to state this and that
contributors should be aware that a request to split apart unwieldy PRs is a
potential consequence. I don't think there is (or should be) a hard guideline,
but we're going to have to adjust to avoid repeating these types of things in
the future.
I do however, think that we need a more formalized test plan, just for no
other reason than that seems like the easiest way to dig into something of this
size.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
