GitHub user mattf-horton opened a pull request:
https://github.com/apache/metron/pull/616
METRON-877 Extract core implementation and UDF support, create
metron-stellar module
## Contributor Comments
It appears that github permanently closes any PR that gets rebased, hence
for the history and discussion to date, I can only point you at the previous
incarnation of this PR: https://github.com/apache/metron/pull/610
The design document has been available for some time at
https://docs.google.com/document/d/1EP7Jt4ePHe2A-_oboLl2QbN1muh7uKeET_kbpIgjcJM/edit#
I have now added a new section, starting on p. 7, titled "Retrospective:
Changes made for Parts 1 & 2" that details the specific changes actually done
in this PR to extract Stellar.
## Pull Request Checklist
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
The intent of these changes is to achieve an architecture change WITHOUT
any functional change. The continued working of all unit tests, integration
tests and real-world applications should result. In addition, it generates (in
metron-stellar/stellar-common/target) a stellar-common uber-jar (including all
dependencies), which among other things can run the Stellar shell as a
stand-alone Java application (although missing those Stellar functions that
remain as part of Metron):
```
java -cp target/stellar-common-0.4.0-uber.jar \
org.apache.metron.stellar.common.shell.StellarShell
```
For testing within Metron, the stellar classes are still incorporated into
the metron-common jar and RPM, so test installation should work as before.
For a general test plan for all Stellar functionality within Metron, please
see #468 's test plan.
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [IN PROCESS] Have you verified the basic functionality of the build by
building and running locally with Vagrant full-dev environment or the
equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattf-horton/metron stellar-mod4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/616.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #616
----
commit 9927da1f24b23985c129c5996e92292c14270fb9
Author: mattf-horton <[email protected]>
Date: 2017-06-05T22:15:15Z
Stellar extraction - first commit, steps 1 and 2.
commit d00588f03ab05625ced694cda0621a78694adeed
Author: mattf-horton <[email protected]>
Date: 2017-06-07T06:45:04Z
corrections for build_utils/verify_licenses.sh
commit ed78af4bf4a0e9ae4c88c1326531b6d61bc18ecc
Author: mattf-horton <[email protected]>
Date: 2017-06-08T01:20:52Z
fix for EnrichmentConfigFunctionsTest issue
commit 8ce3d8a52f5758c740d0dd4664cdbe9969b2be95
Author: mattf-horton <[email protected]>
Date: 2017-06-09T21:18:21Z
fix RPM generation after stellar separation. Stellar-common continues to
be built into metron-common uber-jar.
commit 1349dcc85b75b621922c8c01fcbe6ba3d569ce1e
Author: mattf-horton <[email protected]>
Date: 2017-06-10T00:45:01Z
cleanup after rebase to current master
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
