Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/586#discussion_r123051416
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/files/bro_index.template
---
@@ -238,6 +238,538 @@
"qtype_name": {
"type": "string",
"index": "not_analyzed"
+ },
+ "analyzer": {
+ "type": "string",
+ "index": "not_analyzed"
+ },
+ "failure_reason": {
--- End diff --
The refactor of this template that you suggest seems scary to me without
some comments. Duplicate names seem also like something that should be called
out in comments. There is some useful information here that can only be found
in this PR and won't live-on with the code, unfortunately.
But at least it looks like you have one test record per new log type, so
the integration tests should fail if a refactor of the index template goes
badly. **I think?**
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
