Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/621#discussion_r123413205
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/topology/ParserTopologyBuilder.java
---
@@ -132,7 +132,14 @@ public static TopologyBuilder build(String
zookeeperUrl,
if(securityProtocol.isPresent()) {
kafkaSpoutConfigOptions.putIfAbsent("security.protocol",
securityProtocol.get());
}
- return SimpleStormKafkaBuilder.create(inputTopic, zkQuorum,
Arrays.asList("value"), kafkaSpoutConfigOptions);
+ return SimpleStormKafkaBuilder.create( inputTopic
--- End diff --
This seems likely to have conflict. The assumption that these simple names
may never already be a part of a message. In general, the metadata is
nebulous. The metadata fields should be prefixed and discoverable by other
processes, without knowing before hand.
Some call Map<?,?> getMetadata(JSONObject message) should be implementable
without hard coding.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
