Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/624#discussion_r124821164
--- Diff:
metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/integration/ParserDriver.java
---
@@ -0,0 +1,168 @@
+/**
--- End diff --
As I see it, there are a couple of things we want to test for every parser:
* The parser works (i.e. the unit tests we currently have)
* The parser can be driven from within the `ParserBolt` (the current
integration tests as of this PR)
Beyond that, I think it's reasonable to have a `ParserIntegrationTest`
which just validates data flows through the parser topology assuming a
correctly working parser and just validates that things work within Storm. I
would not expect every parser to require this kind of test. We have something
similar to that in `SimpleHbaseEnrichmentWriterIntegrationTest`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
