GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/634
METRON-1017: Ambari components should be separate
## Contributor Comments
This PR separates the various configurations in Ambari into different
*-env.xml files. Doing this allows us to create more granular dependencies so
that a configuration change only requires a restart of the affected components
and not the whole service. Previously any change to any configuration would
require every Metron component to be restarted. There was also a small amount
of refactoring done to the enrichment and indexing topics in MPack scripts to
make them more clear and consistent.
This can be tested by spinning up full dev and changing various
configurations. A configuration change should now only prompt to restart the
affected components instead of all components.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-1017
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/634.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #634
----
commit 85608e971fc15846d49c6701e1196f2c18e0ec9f
Author: merrimanr <[email protected]>
Date: 2017-07-05T16:31:36Z
initial commit
commit 4f15918c13bc55e70144ca70f067cc4d17845f26
Author: merrimanr <[email protected]>
Date: 2017-07-06T12:38:07Z
Merge remote-tracking branch 'mirror/master' into METRON-1017
commit c64cd752869f49309b8bee17a1a8740e25b4d4a9
Author: merrimanr <[email protected]>
Date: 2017-07-06T12:42:45Z
newline cleanup
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
