GitHub user merrimanr opened a pull request:
https://github.com/apache/metron/pull/635
METRON-1018: Integration tests should reference flux yaml and property
files deployed by Ambari
## Contributor Comments
This PR makes a couple of improvements to our integration tests.
Enrichment and integration tests now set properties using the same
templates as the Ambari MPack. This will make our tests easier to maintain
because there is now a single source of properties. Any
addition/subtraction/modification to those properties will be detected in the
tests.
The EnrichmentIntegrationTest now uses a single flux file instead of having
a dedicated test flux file. This was problematic because a) two flux files
needed to be maintained for one topology and b) the test flux file could easily
become stale and no longer accurately represent the enrichment topology (this
happened to me on METRON-990). The introduction of Stellar (this test was
written a while ago) makes it possible to simulate an error so a modified
topology/flux file with an error generating bolt is no longer required.
As a result of adding an error-generating Stellar statement I encountered a
bug in the GenericEnrichmentBolt. The exception thrown by the Stellar adapter
was being reported twice: once on line 235 and again on line 275. I attempted
to fix this by removing the "error" flag and just reporting the error right
when it happens. There are likely multiple ways to do this so I want to
highlight this class for reviewers. Suggestions and scrutiny needed here.
Testing this is simple: all tests should pass without issue. Any change
to the templates or enrichment flux file should break the tests. I also
ensured full dev starts up without issue.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-1018
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/635.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #635
----
commit 7e087da2411c19ccb34c49677beacfa15aadf38b
Author: merrimanr <[email protected]>
Date: 2017-07-05T23:34:37Z
initial commit
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
