GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/638
METRON-933 New stellar function for regex group capture
New Stellar function for capturing a group from a Regex Pattern.
I created a new RegExFunctions in Stellar for this, and moved the existing
RegEx Match function there.
I also created the corresponding test class, and added a test for the
existing RegEx Match function as well, since there didn't seem to be one.
To support these functions I created a thread local cache for compiled
Pattern objects.
Testing -> Build, run tests
Start stellar shell and execute the functions.
### For all changes:
- [x ] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x ] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [ x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x ] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x ] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ottobackwards/metron stellar_regex_capture
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/638.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #638
----
commit 3d7a79d2afaeb521113f1d77ba6211a0a52e8401
Author: Otto Fowler <[email protected]>
Date: 2017-07-07T18:52:04Z
New stellar function for regex group capture
Create a test for existing regex match function
Move both to RegExFunctions
Create a cache for compiled patterns (thread local)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
