Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/metron/pull/641#discussion_r126481330
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/HashFunctionsTest.java
---
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.metron.stellar.dsl.functions;
+
+import com.google.common.io.BaseEncoding;
+import org.apache.commons.lang.SerializationUtils;
+import org.junit.Test;
+
+import java.io.Serializable;
+import java.nio.charset.StandardCharsets;
+import java.security.MessageDigest;
+import java.security.NoSuchAlgorithmException;
+import java.security.Security;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Set;
+
+import static
org.apache.metron.stellar.common.utils.StellarProcessorUtils.run;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNull;
+
+public class HashFunctionsTest {
+ final HashFunctions.Hash hash = new HashFunctions.Hash();
+
+ @Test(expected = IllegalArgumentException.class)
+ public void nullArgumentListShouldThrowException() throws Exception {
+ hash.apply(null);
+ }
+
+ @Test(expected = IllegalArgumentException.class)
+ public void emptyArgumentListShouldThrowException() throws Exception {
+ hash.apply(Collections.emptyList());
+ }
+
+ @Test(expected = IllegalArgumentException.class)
+ public void singleArgumentListShouldThrowException() throws Exception {
+ hash.apply(Collections.singletonList("some value."));
+ }
+
+ @Test(expected = IllegalArgumentException.class)
+ public void argumentListWithMoreThanTwoValuesShouldThrowException3()
throws Exception {
+ hash.apply(Arrays.asList("1", "2", "3"));
+ }
+
+ @Test(expected = IllegalArgumentException.class)
+ public void argumentListWithMoreThanTwoValuesShouldThrowException4()
throws Exception {
+ hash.apply(Arrays.asList("1", "2", "3", "4"));
+ }
+
+ @Test(expected = IllegalArgumentException.class)
+ public void invalidAlgorithmArgumentShouldThrowException() throws
Exception {
+ hash.apply(Arrays.asList("value to hash", "invalidAlgorithm"));
+ }
+
+ @Test
+ public void invalidNullAlgorithmArgumentShouldThrowException() throws
Exception {
+ assertNull(hash.apply(Arrays.asList("value to hash", null)));
+ }
+
+ @Test
+ public void nullInputForValueToHashShouldProperlyThrowException() throws
Exception {
+ assertNull(hash.apply(Arrays.asList(null, "md5")));
+ }
+
+ @Test
+ public void allAlgorithmsForMessageDigestShouldBeAbleToHash() throws
Exception {
+ final String valueToHash = "My value to hash";
+ final Set<String> algorithms = Security.getAlgorithms("MessageDigest");
+
+ algorithms.forEach(algorithm -> {
+ try {
+ final MessageDigest m = MessageDigest.getInstance(algorithm);
+ m.update(valueToHash.getBytes(StandardCharsets.UTF_8));
+
+ assertEquals(BaseEncoding.base16().encode(m.digest()),
hash.apply(Arrays.asList(valueToHash, algorithm)));
+ } catch (NoSuchAlgorithmException e) {
+ throw new RuntimeException(e);
+ }
+ });
+ }
+
+ @Test
+ public void
allAlgorithmsForMessageDigestShouldBeAbleToHashDirectStellarCall() throws
Exception {
+ final String valueToHash = "My value to hash";
+ final Set<String> algorithms = Security.getAlgorithms("MessageDigest");
+
+ algorithms.forEach(algorithm -> {
+ try {
+ final Object actual = run("HASH('" + valueToHash + "', '" +
algorithm + "')", Collections.emptyMap());
+
+ final MessageDigest m = MessageDigest.getInstance(algorithm);
+ m.update(valueToHash.getBytes(StandardCharsets.UTF_8));
+
+ assertEquals(BaseEncoding.base16().encode(m.digest()), actual);
+ } catch (NoSuchAlgorithmException e) {
+ throw new RuntimeException(e);
+ }
+ });
+ }
+
+ @Test
+ public void
nonStringValueThatIsSerializableShouldBeSerializedAndThenEncodedUsingHex()
throws Exception {
--- End diff --
This is another nit, but I'll share the thought anyway: A more typical
(and shorter) name would be "testNonStringValueThatIsSerializable". Being a
"test", it is understood that the normative result is to properly do whatever
it should do without error. Similarly, the next two items could more briefly
be named "testHashFunctionsWithVariablesAsInput" and
"testStellarFunctionWhereOnlyHashTypeIsAVariable".
The last one,
"aNonNullObjectThatDoesNotImplementSerializableShouldReturnAValueOfNull" is for
a non-normative case, so it provides useful information as is. It could still
be shorter though. How about "testNonSerializableObjectReturnsNull"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
