Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/644
@justinleet Another thing I noticed while in the code is that a lookup of a
private IP address is expected to return an empty map. Since we're using an
Optional, wouldn't it make more sense for it to return `Optional.empty()`?
The javadocs say that `Optional.empty()` indicates a lookup miss, not an
empty map. I could either make it return `Optional.empty()` or I could update
the docs so that they match current behavior. Let me know what you think.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
