Github user cestella commented on the issue:
https://github.com/apache/metron/pull/636
I just want to follow-up with something a bit more concrete suggestions. I
think the beginnings of an abstraction are there. You pulled out a bunch of
utility methods from `ElasticsearchWriter` which is good. I'm looking for a
DAO-like abstraction in `metron-elasticsearch` and the `ServiceImpl` in the
REST layer uses the generic DAO implementation (which would not live in the
REST layer so it's usable for lower level access) and the index impl is
specified by at runtime. The impl for the DAO would live in one of
`metron-elasticsearch` or `metron-solr`.
Again, these are my $0.02 and just suggestions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
