Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/654#discussion_r127531933
--- Diff:
metron-platform/metron-writer/src/test/java/org/apache/metron/writer/BulkWriterComponentTest.java
---
@@ -118,6 +118,20 @@ public void writeShouldProperlyAckTuplesInBatch()
throws Exception {
}
@Test
+ public void writeShouldProperlyAckTuplesWhenWriterDisabled() throws
Exception {
--- End diff --
I combined the test for a disabled sensor into the previous test for
enabled sensors. Is this ok? Otherwise we'll have 2 tests that look almost
identical.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
