Github user justinleet commented on a diff in the pull request:
https://github.com/apache/metron/pull/660#discussion_r128895474
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_commands.py
---
@@ -95,32 +95,46 @@ def init_hdfs_dir(self):
)
Logger.info('Done creating HDFS indexing directory')
- def start_indexing_topology(self):
- Logger.info("Starting Metron indexing topology:
{0}".format(self.__indexing_topology))
- start_cmd_template = """{0}/bin/start_elasticsearch_topology.sh \
+ def start_indexing_topology(self, env):
+ Logger.info('Starting ' + self.__indexing_topology)
+
+ if self.is_topology_active(env):
--- End diff --
Same deal with the negated condition
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
