Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/662#discussion_r129145507
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/SearchController.java
---
@@ -45,4 +49,18 @@
ResponseEntity<SearchResponse> search(final @ApiParam(name =
"searchRequest", value = "Search request", required = true) @RequestBody
SearchRequest searchRequest) throws RestException {
return new ResponseEntity<>(searchService.search(searchRequest),
HttpStatus.OK);
}
+
--- End diff --
It's a legitimate concern but I think synchronous is ok here because
Elasticsearch is intended to provide results in real-time. The http javascript
APIs we use are asynchronous so it shouldn't make a difference in the UI. If
this were a batch operation (Hive, Map Reduce) I would agree that it should be
an async call.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
