Github user mattf-horton commented on a diff in the pull request:

    https://github.com/apache/metron/pull/656#discussion_r129219973
  
    --- Diff: metron-analytics/metron-profiler/README.md ---
    @@ -17,7 +17,7 @@ Any field contained within a message can be used to 
generate a profile.  A profi
     
     Follow these instructions to install the Profiler.  This assumes that core 
Metron has already been installed and validated.  
     
    -1. Build the Metron RPMs by [following these 
instructions](../../metron-deployment#rpm).  
    +1. Build the Metron RPMs (see Building the 
[RPM](../../metron-deployment#rpm)s).  
    --- End diff --
    
    Suggest: please consider changing the referenced h2 title in 
metron-deployment/README.md to "RPMs", so that you can then include the entire 
actual header anchor text in the square brackets and corresponding link name in 
the parentheses; ie, \[RPMs\]\(../../metron-deployment#rpms\)  Chunking it like 
this patch makes the fix-up semantics much harder to reason about (and gives 
ugly links that aren't whole words). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to