GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/666
Metron 1051 2
## Contributor Comments
Currently our indexing layer is immutable. It would be useful to be able to:
* Update data in the indices
* Track lineage for updates
Current version of data should be able to be exposed via a batch interface.
Updates should be available via a Java DAO API as well as via the REST API.
Implementation should ensure that the ability to read the current data in
batch is possible.
TODO: A proper manual validation script is pending.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cestella/incubator-metron METRON-1051-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/666.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #666
----
commit f4380781540314a923dbc9b1ce61d6dd6a0afdf6
Author: cstella <[email protected]>
Date: 2017-07-20T12:38:34Z
METRON-1051: Add update capability. DAO Layer is complete, lacking REST
layer.
commit a29945c704c375f5ac56e8d63ab73a34694790ce
Author: cstella <[email protected]>
Date: 2017-07-20T13:18:20Z
Updating REST and testing to consolidate one MockHTableProvider
commit ad535c911196d7c24fd6fddc8c082ce2b0b4d859
Author: cstella <[email protected]>
Date: 2017-07-20T17:53:07Z
Updating REST api tests.
commit 87c446b1fe41316a087ba2abac4faa5342507a01
Author: cstella <[email protected]>
Date: 2017-07-20T18:44:38Z
Added licenses
commit c36c12c80a64d9575395475114695746885e3f52
Author: cstella <[email protected]>
Date: 2017-07-20T19:59:10Z
Updating to add guid as the proper ID.
commit b1989dee7810f0f0e8f5bc5fbd45879e7f4b63d2
Author: cstella <[email protected]>
Date: 2017-07-20T20:51:49Z
Updating to include upsert and optional search for index.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
