Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/metron/pull/607#discussion_r129904369
  
    --- Diff: 
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/StormStatusServiceImpl.java
 ---
    @@ -17,10 +17,7 @@
      */
     package org.apache.metron.rest.service.impl;
     
    -import org.apache.metron.rest.model.TopologyResponse;
    -import org.apache.metron.rest.model.TopologyStatus;
    -import org.apache.metron.rest.model.TopologyStatusCode;
    -import org.apache.metron.rest.model.TopologySummary;
    +import org.apache.metron.rest.model.*;
    --- End diff --
    
    @merrimanr @mattf-horton We did not have an official vote.  Given the 
widespread acceptance of it, since it's not a dev guildelines and not a bylaw 
thing, my impression was we didn't need it. Having said that, if it needs or 
should have an actual vote, I'm definitely okay with it and it should be done 
before https://github.com/apache/metron/pull/577 goes in.
    
    However, 577 is still outstanding pending additional feedback I requested.  
I was inclined to not update the wiki, because we hadn't built out and 
validated the tooling at the time.  I personally lean towards updating the wiki 
once we're good with that PR going in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to