GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/676
METRON-1072: Cleanup Maven build warnings
https://issues.apache.org/jira/browse/METRON-1072
## Contributor Comments
This one is pretty straightforward. Our build outputs a large amount of
avoidable WARNING noise. This PR cleans up quite a bit of low-hanging fruit,
including:
- The expression ${parent.version} is deprecated. Please use
${project.parent.version} instead.
- Using platform encoding (UTF-8 actually) to copy filtered resources, i.e.
build is platform dependent!
- File encoding has not been set, using platform encoding UTF-8, i.e. build
is platform dependent!
- The assembly descriptor contains a filesystem-root relative reference,
which is not cross platform compatible /bin
- site-book: JAR will be empty - no content was marked for inclusion!
There are also a number of warnings pertaining to overlapping classes found
during the shading process. And a number of npm related issues, e.g. "npm WARN
deprecated [email protected]: Please update to minimatch 3.0.2 or higher to
avoid a RegExp DoS issue". This is not addressed by this work.
To test this, run full-dev and verify data flows through indexing. The
biggest concern would be around the path changes (removing leading slash '/')
in the assembly.xml files. In spite of the examples included in
https://maven.apache.org/guides/mini/guide-assemblies.html, this results in a
potentially platform-dependent build. Excluding leading slashes addresses these
warnings.
## Pull Request Checklist
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmiklavc/metron cleanup-maven-warnings
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/676.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #676
----
commit c10a8eed3a148745b1ce5126d762151e20a7e357
Author: Michael Miklavcic <[email protected]>
Date: 2017-08-01T20:34:09Z
METRON-1072: Cleanup Maven build warnings
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
