GitHub user ottobackwards opened a pull request:

    https://github.com/apache/metron/pull/686

    METRON-711 STELLAR SHELL Do not set variables when exceptions are thrown 
from assignment.

    This PR changes the behavior of the Stellar Shell such that when doing 
variable assignments ( VAR := EXPRESSION ) that result in an exception ( foo := 
TO_UPPER(IN) ) do not continue to set / create foo after catching the exception.
    
    
    ## Testing 
    
    - Start the stellar shell
    - Execute a statement that may throw an exception, the easiest is an 
invalid expression like
    ```bash
    > foo := TO_UPPER(IN)
    ```
    
    - Verify that there is a statement that the variable will not be set
    - Verify that the exception and stack is printed
    - Verify that the variable was not in fact set:
    
    ```bash
    > %vars
    ```
    
    Also, test creating a variable, and that it is not modified
    
    ```bash
    > bar := 'one'
    > bar := TO_UPPER(IN)
    > bar
    > %vars
    ```
    
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [ ] Have you written or updated unit tests and or integration tests to 
verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [x] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ottobackwards/metron stellar_shell_ex

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/686.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #686
    
----
commit 215dc969026fa557a0a0f3efb9fe2bc170666b9a
Author: Otto Fowler <ottobackwa...@gmail.com>
Date:   2017-08-06T02:14:51Z

    Do not set variables when exceptions are thrown from assignment.
    Also remove executeStellar which is not required, if it doesn't eat the 
exception

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to