Github user mattf-horton commented on a diff in the pull request:

    https://github.com/apache/metron/pull/530#discussion_r131794169
  
    --- Diff: 
bundles-lib/src/main/java/org/apache/metron/bundles/bundle/BundleCoordinate.java
 ---
    @@ -0,0 +1,90 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron.bundles.bundle;
    +
    +/**
    + * The coordinates of a bundle (group, artifact, version).
    + */
    +public class BundleCoordinate {
    +
    +    public static final String DEFAULT_GROUP = "default";
    +    public static final String DEFAULT_VERSION = "unversioned";
    +
    +    public static final BundleCoordinate UNKNOWN_COORDINATE = new 
BundleCoordinate(DEFAULT_GROUP, "unknown", DEFAULT_VERSION);
    +
    +    private final String group;
    +    private final String id;
    +    private final String version;
    +    private final String coordinate;
    +
    +    public BundleCoordinate(final String group, final String id, final 
String version) {
    +        this.group = isBlank(group) ? DEFAULT_GROUP : group;
    +        this.id = id;
    +        this.version = isBlank(version) ? DEFAULT_VERSION : version;
    +
    +        if (isBlank(id)) {
    +            throw new IllegalStateException("Id is required for 
BundleCoordinate");
    +        }
    +
    +        this.coordinate = this.group + ":" + this.id + ":" + this.version;
    --- End diff --
    
    Since ":" is the delimiter, you should check for it in group, id, and 
version, and reject if found.
    If appropriate, you might also check for character set used, perhaps 
enforcing the Maven standards for which characters can be used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to