Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/530#discussion_r132807655
  
    --- Diff: 
bundles-lib/src/main/java/org/apache/metron/bundles/BundleThreadContextClassLoader.java
 ---
    @@ -0,0 +1,221 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.metron.bundles;
    +
    +import java.io.IOException;
    +import java.io.InputStream;
    +import java.lang.reflect.Constructor;
    +import java.lang.reflect.InvocationTargetException;
    +import java.net.URL;
    +import java.net.URLClassLoader;
    +import java.util.ArrayList;
    +import java.util.Enumeration;
    +import java.util.List;
    +import java.util.concurrent.atomic.AtomicBoolean;
    +
    +import org.apache.metron.bundles.bundle.Bundle;
    +import org.apache.metron.bundles.util.BundleProperties;
    +
    +/**
    + * THREAD SAFE
    + */
    +public class BundleThreadContextClassLoader extends URLClassLoader {
    +
    +    static final ContextSecurityManager contextSecurityManager = new 
ContextSecurityManager();
    +    private final ClassLoader forward = ClassLoader.getSystemClassLoader();
    +    private static final List<Class<?>> bundleSpecificClasses = new 
ArrayList<>();
    +    private static AtomicBoolean inited = new AtomicBoolean(false);
    +    // should initialize class definitions
    +    public static void initClasses(final List<Class> classes){
    --- End diff --
    
    I don't like them either.  I thought about DI and other things, but I was 
avoiding major changes of that type.  I'm more willing now to part ways.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to