Github user JonZeolla commented on the issue:

    https://github.com/apache/metron/pull/690
  
    +1, visual inspection + a bit of playing around (see below).
    
    ```
    ~/bin$ ./stellar
    SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
    SLF4J: Defaulting to no-operation (NOP) logger implementation
    SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further 
details.
    log4j:WARN No appenders could be found for logger 
(org.apache.metron.stellar.beanutils.converters.BooleanConverter).
    log4j:WARN Please initialize the log4j system properly.
    log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for 
more info.
    Stellar, Go!
    Please note that functions are loading lazily in the background and will be 
unavailable until loaded fully.
    [Stellar]>>> Functions loaded, you may refer to functions now...
    
    [Stellar]>>> TO_DOUBLE(2)
    2.0
    [Stellar]>>> TO_INTEGER(SQRT(64))
    8
    [Stellar]>>> TO_UPPER('ThIS is A TEsT of MetRoN-1091')
    THIS IS A TEST OF METRON-1091
    [Stellar]>>> CHOP('2093j0f29k30fk230f2j309jf')
    2093j0f29k30fk230f2j309j
    [Stellar]>>> COUNT_MATCHES('the quick brown fox jumped over the lazy dog', 
'o')
    4
    [Stellar]>>> DAY_OF_YEAR(1502592512)
    18
    [Stellar]>>> DAY_OF_MONTH(1502592512)
    18
    ~$ bin/stellar
    SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
    SLF4J: Defaulting to no-operation (NOP) logger implementation
    SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further 
details.
    log4j:WARN No appenders could be found for logger 
(org.apache.metron.stellar.beanutils.converters.BooleanConverter).
    log4j:WARN Please initialize the log4j system properly.
    log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for 
more info.
    Stellar, Go!
    Please note that functions are loading lazily in the background and will be 
unavailable until loaded fully.
    [Stellar]>>> Functions loaded, you may refer to functions now...
    
    [Stellar]>>> DAY_OF_YEAR(1502592893)
    18
    [Stellar]>>> DAY_OF_MONTH(1502592893)
    18
    [Stellar]>>> COUNT_MATCHES('the quick brown fox jumped over the lazy dog', 
'o')
    4
    ```
    
    Opened [METRON-1107](https://issues.apache.org/jira/browse/METRON-1107) for 
the DAY_OF_{YEAR,MONTH} issue, otherwise looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to