Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/740#discussion_r137924431
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/shell/StellarShell.java
---
@@ -308,17 +315,68 @@ private void handleMagic( String rawExpression) {
.collect(Collectors.joining(", "));
writeLine(functions);
- } else if(MAGIC_VARS.equals(command)) {
+ } else if (MAGIC_VARS.equals(command)) {
- // list all variables
+ // '%vars' -> list all variables in scope
executor.getVariables()
- .forEach((k,v) -> writeLine(String.format("%s = %s", k, v)));
+ .forEach((k, v) -> writeLine(String.format("%s = %s", k,
v)));
+
+ } else if (MAGIC_GLOBALS.equals(command)) {
+
+ // '%globals' -> list all globals in scope
+ Map<String, Object> globals = Collections.emptyMap();
--- End diff --
I do not see a problem here. Functions need whatever GLOBAL_CONFIG
settings they need. This PR does not make it harder or less likely for
functions to get the values they need. This PR makes it easier for a user to
provide the settings, or alter the settings that a function needs. IMHO
---
